ankit0811 opened a new pull request, #14462: URL: https://github.com/apache/druid/pull/14462
Fixes #10702 ### Description This PR revives https://github.com/apache/druid/pull/10949 which address issue #10702 by adding support for doubleLast, doubleFirst, FloatLast, FloatFirst, longLast and longFirst. It follows the code flow similar to stringFirst and stringLast #### Release note <hr> ##### Key changed/added classes in this PR Introduces the following new Classes * `AbstractSerializableLongObjectPairSerde` abstract class to share serde between double/float/long * `SerializablePairLongDoubleComplexMetricSerde` for double * `SerializablePairLongFloatComplexMetricSerde` for float * `SerializablePairLongStringComplexMetricSerde` for long * `GenericFirstAggregateCombiner` first agg combiner to share between double/float/long * `GenericLastAggregateCombiner` first agg combiner to share between double/float/long * `DoubleFirstAggregatorFactory`, `DoubleLastAggregatorFactory` * `FloatFirstAggregatorFactory`, `FloatLastAggregatorFactory` * `LongFirstAggregatorFactory`, `LongLastAggregatorFactory` Further introduces new `ColumnType` * serializablePairLongDouble * serializablePairLongFloat * serializablePairLongString To-Do These will be taken up in a follow-up PR - SerializablePairLongStringComplexMetricSerde to extend AbstractSerializableLongObjectPairSerde - Add ingestion support from UI for first/last types - SQL compatibility for querying (latest/earliest) the new ingestion type (Today this is queryable via native json queries not via sql. Needs more discussion on making this SQL compatible) <hr> This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] added integration tests. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
