ankit0811 commented on code in PR #14462:
URL: https://github.com/apache/druid/pull/14462#discussion_r1266218893
##########
processing/src/main/java/org/apache/druid/query/aggregation/first/DoubleFirstAggregatorFactory.java:
##########
@@ -100,27 +106,37 @@ public DoubleFirstAggregatorFactory(
@Override
public Aggregator factorize(ColumnSelectorFactory metricFactory)
{
- final BaseDoubleColumnValueSelector valueSelector =
metricFactory.makeColumnValueSelector(fieldName);
+ final ColumnValueSelector valueSelector =
metricFactory.makeColumnValueSelector(fieldName);
if (valueSelector instanceof NilColumnValueSelector) {
return NIL_AGGREGATOR;
} else {
return new DoubleFirstAggregator(
metricFactory.makeColumnValueSelector(timeColumn),
- valueSelector
+ valueSelector,
+ StringFirstLastUtils.selectorNeedsFoldCheck(
+ valueSelector,
+ metricFactory.getColumnCapabilities(fieldName),
+ SerializablePairLongDouble.class
+ )
);
}
}
@Override
public BufferAggregator factorizeBuffered(ColumnSelectorFactory
metricFactory)
{
- final BaseDoubleColumnValueSelector valueSelector =
metricFactory.makeColumnValueSelector(fieldName);
+ final ColumnValueSelector valueSelector =
metricFactory.makeColumnValueSelector(fieldName);
if (valueSelector instanceof NilColumnValueSelector) {
return NIL_BUFFER_AGGREGATOR;
} else {
return new DoubleFirstBufferAggregator(
metricFactory.makeColumnValueSelector(timeColumn),
- valueSelector
+ valueSelector,
+ StringFirstLastUtils.selectorNeedsFoldCheck(
Review Comment:
Ack. Will create a new numeric util
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
