LakshSingla opened a new pull request, #14475:
URL: https://github.com/apache/druid/pull/14475
### Description
Currently, if you run the two queries like below:
```sql
1. insert into mytest select time_parse(ts) as __time, c1 from
(values('2022-01-01 00:00:00', 'A')) as t(ts, c1) partitioned by MONTH
2. insert into mytest select time_parse(ts) as __time, c1 from
(values('2022-01-02 00:00:00', 'A')) as t(ts, c1) partitioned by DAY
```
The second one allocates a segment with MONTH granularity, even though the
partitioning has stated DAY granularity.
This is because the overlord does a best-effort job of fetching the segment
with the requested granularity and in case a pre-existing segment is there that
overlaps the requested segment, the overlord returns that segment (which might
not match the requested granularity).
This is semantically incorrect since the user has requested a segment of DAY
granularity and this should return an error instead. This PR adds the desired
checks to prevent the described case from happening.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
