AmatyaAvadhanula commented on code in PR #14484:
URL: https://github.com/apache/druid/pull/14484#discussion_r1242516617
##########
server/src/test/java/org/apache/druid/server/coordinator/balancer/CostBalancerStrategyTest.java:
##########
@@ -334,42 +367,10 @@ public void
testFindServerAfterExecutorShutdownThrowsException()
);
}
- @Test(timeout = 90_000L)
- public void testFindServerRaisesAlertOnTimeout()
+ private void verifyPlacementCost(DataSegment segment, ServerHolder server,
double expectedCost)
Review Comment:
Why do we manually pass the expectedCost?
Can we not compare the results of the method `computePlacementCost` with the
sum of individual costs of the candidate segment across all segments on the
server (i.e the original implementation)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
