kfaraz commented on code in PR #14484:
URL: https://github.com/apache/druid/pull/14484#discussion_r1242566508
##########
server/src/test/java/org/apache/druid/server/coordinator/balancer/CostBalancerStrategyTest.java:
##########
@@ -334,42 +367,10 @@ public void
testFindServerAfterExecutorShutdownThrowsException()
);
}
- @Test(timeout = 90_000L)
- public void testFindServerRaisesAlertOnTimeout()
+ private void verifyPlacementCost(DataSegment segment, ServerHolder server,
double expectedCost)
Review Comment:
Sure, that can be another assertion in this test or another test.
This particular test was added to ensure that cost remains the same even
when we make changes to the way cost is computed, such as in this PR. That is
why the exact numerical literals have been used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
