github-code-scanning[bot] commented on code in PR #14416: URL: https://github.com/apache/druid/pull/14416#discussion_r1243975717
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/entity/SqlStatementResult.java: ########## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.msq.sql.entity; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonInclude; +import com.fasterxml.jackson.annotation.JsonProperty; +import org.apache.druid.error.ErrorResponse; +import org.apache.druid.msq.sql.SqlStatementState; +import org.joda.time.DateTime; + +import javax.annotation.Nullable; +import java.util.List; +import java.util.Objects; + +public class SqlStatementResult +{ + + private final String queryId; + + private final SqlStatementState state; + + private final DateTime createdAt; + + @Nullable + private final List<ColumnNameAndTypes> sqlRowSignature; + + @Nullable + private final Long durationMs; + + @Nullable + private final ResultSetInformation resultSetInformation; + + @Nullable + private final ErrorResponse errorResponse; + + + @JsonCreator + public SqlStatementResult( + @JsonProperty("queryId") + String queryId, + @JsonProperty("state") + SqlStatementState state, + @JsonProperty("createdAt") + DateTime createdAt, + @Nullable @JsonProperty("schema") + List<ColumnNameAndTypes> sqlRowSignature, + @Nullable @JsonProperty("durationMs") + Long durationMs, + @Nullable @JsonProperty("result") + ResultSetInformation resultSetInformation, + @Nullable @JsonProperty("errorDetails") + ErrorResponse errorResponse + + ) + { + this.queryId = queryId; + this.state = state; + this.createdAt = createdAt; + this.sqlRowSignature = sqlRowSignature; + this.durationMs = durationMs; + this.resultSetInformation = resultSetInformation; + this.errorResponse = errorResponse; + } + + @JsonProperty + public String getQueryId() + { + return queryId; + } + + @JsonProperty + public SqlStatementState getState() + { + return state; + } + + @JsonProperty + public DateTime getCreatedAt() + { + return createdAt; + } + + @JsonProperty("schema") + @Nullable + @JsonInclude(JsonInclude.Include.NON_NULL) + public List<ColumnNameAndTypes> getSqlRowSignature() + { + return sqlRowSignature; + } + + @JsonProperty + @Nullable + @JsonInclude(JsonInclude.Include.NON_NULL) + public Long getDurationMs() + { + return durationMs; + } + + @JsonProperty("result") + @Nullable + @JsonInclude(JsonInclude.Include.NON_NULL) + public ResultSetInformation getResultSetInformation() + { + return resultSetInformation; + } + + @JsonProperty("errorDetails") + @Nullable + @JsonInclude(JsonInclude.Include.NON_NULL) + public ErrorResponse getErrorResponse() + { + return errorResponse; + } + + + @Override + public boolean equals(Object o) + { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + SqlStatementResult that = (SqlStatementResult) o; + return Objects.equals(queryId, that.queryId) && state == that.state && Objects.equals( + createdAt, + that.createdAt + ) && Objects.equals(sqlRowSignature, that.sqlRowSignature) && Objects.equals( + durationMs, + that.durationMs + ) && Objects.equals(resultSetInformation, that.resultSetInformation) && Objects.equals( + errorResponse == null ? null : errorResponse.getAsMap(), + that.errorResponse == null ? null : errorResponse.getAsMap() Review Comment: ## Dereferenced variable may be null Variable [errorResponse](1) may be null at this access as suggested by [this](2) null guard. [Show more details](https://github.com/apache/druid/security/code-scanning/5196) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
