adarshsanjeev commented on code in PR #14416:
URL: https://github.com/apache/druid/pull/14416#discussion_r1243654468
##########
sql/src/test/java/org/apache/druid/sql/http/SqlResourceTest.java:
##########
@@ -2056,7 +2056,7 @@ private <T> T deserializeResponse(Response resp, Class<T>
clazz) throws IOExcept
return JSON_MAPPER.readValue(responseToByteArray(resp), clazz);
}
- private byte[] responseToByteArray(Response resp) throws IOException
+ public static byte[] responseToByteArray(Response resp) throws IOException
Review Comment:
Minor nit: Could be pushed up to `CalciteTestBase` so that other classes can
use it in the future
##########
server/src/main/java/org/apache/druid/rpc/indexing/OverlordClient.java:
##########
@@ -52,5 +53,7 @@ public interface OverlordClient
ListenableFuture<Map<String, Object>> taskReportAsMap(String taskId);
+ ListenableFuture<TaskPayloadResponse> taskPayload(String taskId);
Review Comment:
nit: This function might need a better name to avoid confusing it with the
task payload containing results, since we have a payload() function in
SqlStatementResource already. Maybe `taskDefinition`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
