cryptoe commented on code in PR #14416:
URL: https://github.com/apache/druid/pull/14416#discussion_r1244665651
##########
sql/src/test/java/org/apache/druid/sql/http/SqlResourceTest.java:
##########
@@ -2056,7 +2056,7 @@ private <T> T deserializeResponse(Response resp, Class<T>
clazz) throws IOExcept
return JSON_MAPPER.readValue(responseToByteArray(resp), clazz);
}
- private byte[] responseToByteArray(Response resp) throws IOException
+ public static byte[] responseToByteArray(Response resp) throws IOException
Review Comment:
I generally avoid pushing stuff to calcite test base since its already a
big class until necessary. We can probably do that if this method is being used
in other places in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
