gianm commented on issue #14502:
URL: https://github.com/apache/druid/issues/14502#issuecomment-1613900607
For `DruidLogicalValuesRuleTest`, we can remove the mocks from `makeLiteral`
and make real literals instead:
```
private static RexLiteral makeLiteral(Comparable<?> val, SqlTypeName
typeName)
{
return (RexLiteral) new
RexBuilder(DruidTypeSystem.TYPE_FACTORY).makeLiteral(
typeName == SqlTypeName.DECIMAL && val != null ? new
BigDecimal(String.valueOf(val)) : val,
DruidTypeSystem.TYPE_FACTORY.createSqlType(typeName),
false
);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
