kfaraz commented on code in PR #14532:
URL: https://github.com/apache/druid/pull/14532#discussion_r1253894162
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/WorkerTaskRunner.java:
##########
@@ -48,8 +48,11 @@ enum ActionType
/**
* Check which workers can be marked as lazy
+ *
+ * @param isLazyWorker predicate that checks if a worker is lazy
+ * @param maxLazyWorkers maximum number of lazy workers to return
*/
- Collection<Worker> markWorkersLazy(Predicate<ImmutableWorkerInfo>
isLazyWorker, int maxWorkers);
+ Collection<Worker> markWorkersLazy(Predicate<ImmutableWorkerInfo>
isLazyWorker, int maxLazyWorkers);
Review Comment:
Nit: This method name is probably not accurate anymore, because it does not
mark workers as lazy. It gets the list of workers which are lazy and are safe
to terminate. So maybe `getLazyWorkersToTerminate`?
```suggestion
Collection<Worker>
getLazyWorkersToTerminate(Predicate<ImmutableWorkerInfo> isLazyWorker, int
maxToTerminate);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
