gianm commented on code in PR #14532:
URL: https://github.com/apache/druid/pull/14532#discussion_r1253902802
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/WorkerTaskRunner.java:
##########
@@ -48,8 +48,11 @@ enum ActionType
/**
* Check which workers can be marked as lazy
+ *
+ * @param isLazyWorker predicate that checks if a worker is lazy
+ * @param maxLazyWorkers maximum number of lazy workers to return
*/
- Collection<Worker> markWorkersLazy(Predicate<ImmutableWorkerInfo>
isLazyWorker, int maxWorkers);
+ Collection<Worker> markWorkersLazy(Predicate<ImmutableWorkerInfo>
isLazyWorker, int maxLazyWorkers);
Review Comment:
I agree the name is funny, but I didn't want to rename it since it's an
interface method. I figured for interfaces that people might be using in
extensions, best to retain existing signatures unless there is an important
functional reason to change them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
