kfaraz opened a new pull request, #14533:
URL: https://github.com/apache/druid/pull/14533
### Description
`TaskQueue.notifyStatus` is often a heavy call as it performs the following
operations:
- Update task status in metadata DB
- Update task locks in metadata DB
- Request (synchronously) the task runner to shutdown the completed task
- Clean up in-memory data structures
This method can often be slow and can cause worker sync / task runners to
slow down.
### Changes
- Run task completion callbacks in a separate executor to handle task
completion updates
- Add config to handle the number of threads of the new callback executor
- Add metrics to monitor number of processed and queued items
- Use `CoordinatorRunStats` to collect and report metrics. This class has
been used as is for now but will later be renamed and repurposed across all
Druid services.
- Add `TaskCountStatsProvider.getStats()` which deprecates the other
`getXXXTaskCount` methods.
### Pending items
- Tests
- There are still other paths that can invoke `notifyStatus`, those should
probably moved to the new executor too??
#### Release note
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
