kfaraz commented on code in PR #14533:
URL: https://github.com/apache/druid/pull/14533#discussion_r1254342998
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -746,10 +777,16 @@ private void handleStatus(final TaskStatus status)
.addData("statusCode", status.getStatusCode())
.emit();
}
+ finally {
+ statusUpdatesInQueue.decrementAndGet();
+ handledStatusUpdates.incrementAndGet();
+ }
}
- }
+ },
+ // The onSuccess and onFailure should be lightweight enough
+ // so that the executor giving the statusFuture is not blocked
Review Comment:
Simplified this comment, added the rest of the info in the javadoc of this
method as it seemed like a better place for detailed richer content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
