pranavbhole commented on code in PR #14536:
URL: https://github.com/apache/druid/pull/14536#discussion_r1254792593
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteInsertDmlTest.java:
##########
@@ -1435,7 +1436,10 @@ public void
testErrorWithUnableToConstructColumnSignatureWithExtern()
"general"
)
.expectMessageContains(
- "Cannot construct instance of
`org.apache.druid.segment.column.ColumnSignature`, problem:
`java.lang.NullPointerException`\n"
+ JvmUtils.majorVersion() >= 17
+ ? "Cannot construct instance of
`org.apache.druid.segment.column.ColumnSignature`, problem: Cannot invoke
\"String.length()\" because \"s\" is null"
+ :
+ "Cannot construct instance of
`org.apache.druid.segment.column.ColumnSignature`, problem:
`java.lang.NullPointerException`"
Review Comment:
We can shorten the message as well. That will also work. I just want to
highlight the fact that jackson is not bubbling up the generic NPR for jdk
version >17 and giving specific root cause of the NPR exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
