imply-cheddar commented on code in PR #14536:
URL: https://github.com/apache/druid/pull/14536#discussion_r1255258352
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteInsertDmlTest.java:
##########
@@ -1638,6 +1639,9 @@ public void
testErrorWithUnableToConstructColumnSignatureWithExtern()
"general"
)
.expectMessageContains(
+ JvmUtils.majorVersion() >= 17
+ ? "Cannot construct instance of
`org.apache.druid.segment.column.ColumnSignature`, problem: Cannot invoke
\"String.length()\" because \"s\" is null"
+ :
Review Comment:
Can we change the source of the exception to do something that doesn't cause
`NPE`s? There's no way that an end user woudl actually understand what `s` is
and why it needs `length` called on it. Come to think of it, there's probably
no reason to believe that they would even understand what an
`org.apache.druid.segment.column.ColumnSignature` is...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
