imply-cheddar commented on code in PR #14538:
URL: https://github.com/apache/druid/pull/14538#discussion_r1255186054
##########
processing/src/main/java/org/apache/druid/segment/column/ColumnSignature.java:
##########
@@ -50,7 +50,7 @@ class ColumnSignature
// Name must be nonnull, but type can be null (if the type is unknown)
if (name == null || name.isEmpty()) {
- throw new IAE(name, "Column name must be non-empty");
+ throw new IAE("Column name must be provided and non-empty");
Review Comment:
Drive by comment, we could've interpolated the name value here:
```
"Column name [%s] must be provided and non-empty", name
```
Would help differentiate between empty and null. That said, I wonder if
this should be throwing an `InvalidInput` instead of `IAE` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
