LakshSingla commented on code in PR #14538:
URL: https://github.com/apache/druid/pull/14538#discussion_r1255235394
##########
processing/src/main/java/org/apache/druid/segment/column/ColumnSignature.java:
##########
@@ -50,7 +50,7 @@ class ColumnSignature
// Name must be nonnull, but type can be null (if the type is unknown)
if (name == null || name.isEmpty()) {
- throw new IAE(name, "Column name must be non-empty");
+ throw new IAE("Column name must be provided and non-empty");
Review Comment:
@gianm This leads to a 500 error being thrown if the user hits this error,
instead of the 400 (which was the older behavior). Raised a PR yesterday which
addresses this and cleans up exception handling of MSQ bits that reside in the
broker. (https://github.com/apache/druid/pull/14534)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
