LakshSingla commented on code in PR #14534:
URL: https://github.com/apache/druid/pull/14534#discussion_r1258058196
##########
sql/src/main/java/org/apache/druid/sql/calcite/external/ExternalOperatorConversion.java:
##########
@@ -106,28 +106,72 @@ public ExternalTableSpec apply(
}
final RowSignature rowSignature;
if (columns != null) {
- rowSignature = Columns.convertSignature(columns);
+ try {
+ rowSignature = Columns.convertSignature(columns);
+ }
+ catch (IAE e) {
+ throw new ArgumentAndException("columns", e);
+ }
Review Comment:
Seems a lot cleaner. Since the places throwing exceptions are primarily
object mappers, I added the static method for creating the appropriate druid
exception message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
