LakshSingla commented on code in PR #14534:
URL: https://github.com/apache/druid/pull/14534#discussion_r1258475155
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java:
##########
@@ -227,7 +240,9 @@ public QueryResponse<Object[]> runQuery(final DruidQuery
druidQuery)
);
} else {
if (ctxDestination != null &&
!DESTINATION_REPORT.equals(ctxDestination)) {
- throw new IAE("Cannot SELECT with destination [%s]", ctxDestination);
+ throw DruidException.forPersona(DruidException.Persona.DEVELOPER)
+ .ofCategory(DruidException.Category.DEFENSIVE)
+ .build("Cannot SELECT with destination [%s]",
ctxDestination);
Review Comment:
Regarding this, I saw the SYSTEM_CONTEXT has the ctxDestination key,
therefore I assumed that it is set by Druid, hence reaching here would have
been incorrect. There were some changes merged later which I'll go through to
see if this is set internally or by the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
