hqx871 commented on code in PR #11595:
URL: https://github.com/apache/druid/pull/11595#discussion_r1259132010


##########
processing/src/main/java/org/apache/druid/query/CacheStrategy.java:
##########
@@ -43,10 +43,11 @@ public interface CacheStrategy<T, CacheType, QueryType 
extends Query<T>>
    * @param query            the query to be cached
    * @param willMergeRunners indicates that {@link 
QueryRunnerFactory#mergeRunners(QueryProcessingPool, Iterable)} will be
    *                         called on the cached by-segment results
+   * @param bySegment        segment level or result level cache
    *
    * @return true if the query is cacheable, otherwise false.
    */
-  boolean isCacheable(QueryType query, boolean willMergeRunners);
+  boolean isCacheable(QueryType query, boolean willMergeRunners, boolean 
bySegment);

Review Comment:
   get this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to