asdf2014 commented on code in PR #14582:
URL: https://github.com/apache/druid/pull/14582#discussion_r1267871722
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTask.java:
##########
@@ -268,7 +268,27 @@ public boolean withinMinMaxRecordTime(final InputRow row)
protected abstract SeekableStreamIndexTaskRunner<PartitionIdType,
SequenceOffsetType, RecordType> createTaskRunner();
- protected abstract RecordSupplier<PartitionIdType, SequenceOffsetType,
RecordType> newTaskRecordSupplier();
+ /**
+ * Deprecated method for providing the {@link RecordSupplier} that connects
with the stream. New extensions should
+ * overide {@link #newTaskRecordSupplier(TaskToolbox)} instead.
Review Comment:
```suggestion
* override {@link #newTaskRecordSupplier(TaskToolbox)} instead.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
