gianm commented on code in PR #14582:
URL: https://github.com/apache/druid/pull/14582#discussion_r1264079509
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -418,6 +419,13 @@ private TaskStatus runInternal(TaskToolbox toolbox) throws
Exception
try (final RecordSupplier<PartitionIdType, SequenceOffsetType, RecordType>
recordSupplier = task.newTaskRecordSupplier()) {
+ if (toolbox.getMonitorScheduler() != null) {
+ final Monitor monitor = recordSupplier.monitor();
+ if (monitor != null) {
+ toolbox.getMonitorScheduler().addMonitor(monitor);
+ }
+ }
+
Review Comment:
Sounds fine. I'm assuming the goal of the default implementation would be to
generally switch to `newTaskRecordSupplier(TaskToolbox)`, but maintain
compatibility with existing third-party extensions. So to do that, I updated
the patch with these changes:
- Deprecate `newTaskRecordSupplier()`, but keep it around to avoid breaking
extenstions.
- Add `newTaskRecordSupplier(TaskToolbox)` and switch callers and builtin
extensions to use that.
LMK if this matches what you had in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
