kfaraz commented on code in PR #14639:
URL: https://github.com/apache/druid/pull/14639#discussion_r1271333427
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -1760,8 +1761,22 @@ public void updateSegmentMetadata(final Set<DataSegment>
segments)
@Override
public Void inTransaction(Handle handle, TransactionStatus
transactionStatus) throws Exception
{
+ final String updatePayload = StringUtils.format("UPDATE %s SET
payload = :payload WHERE id = :id", dbTables.getSegmentsTable());
+ final PreparedBatch batch = handle.prepareBatch(updatePayload);
+
for (final DataSegment segment : segments) {
Review Comment:
Yeah, I agree with the semantics argument. But I took another look at the
code and it seems that this method is not even being used anywhere except from
a `SegmentMetadataUpdateAction`, which in turn is used by `MoveTask`,
`ArchiveTask` and `RestoreTask`, none of which are in use anymore afaik.
@jasonk000 , did you hit a bottleneck with this SQL too or just the DELETE?
If you did, could you please share more details about the scenario?
If not, we can revert the changes made to this part of the code and just
completely remove this code in a later PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
