jasonk000 commented on code in PR #14639:
URL: https://github.com/apache/druid/pull/14639#discussion_r1271333917


##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -1760,8 +1761,22 @@ public void updateSegmentMetadata(final Set<DataSegment> 
segments)
           @Override
           public Void inTransaction(Handle handle, TransactionStatus 
transactionStatus) throws Exception
           {
+            final String updatePayload = StringUtils.format("UPDATE %s SET 
payload = :payload WHERE id = :id", dbTables.getSegmentsTable());
+            final PreparedBatch batch = handle.prepareBatch(updatePayload);
+
             for (final DataSegment segment : segments) {

Review Comment:
   The bottleneck was just with the DELETE, but I noticed the same pattern, so 
I am happy to revert the update changes. I'll go ahead and do that now (but 
will leave the TC in).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to