kfaraz commented on code in PR #14616:
URL: https://github.com/apache/druid/pull/14616#discussion_r1273006444
##########
server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java:
##########
@@ -272,21 +306,25 @@ private void loadSegment(DataSegment segment,
DataSegmentChangeCallback callback
*
* @throws SegmentLoadingException if it fails to load the given segment
*/
- private void loadSegment(DataSegment segment, DataSegmentChangeCallback
callback, boolean lazy, @Nullable
- ExecutorService loadSegmentIntoPageCacheExec)
- throws SegmentLoadingException
+ private void loadSegment(
+ DataSegment segment,
+ DataSegmentChangeCallback callback,
+ boolean lazy,
+ @Nullable ExecutorService loadSegmentIntoPageCacheExec
+ ) throws SegmentLoadingException
{
final boolean loaded;
try {
- loaded = segmentManager.loadSegment(segment,
- lazy,
- () -> this.removeSegment(segment, DataSegmentChangeCallback.NOOP,
false),
- loadSegmentIntoPageCacheExec
+ loaded = segmentManager.loadSegment(
+ segment,
+ lazy,
+ () -> unannounceAndDropSegment(segment,
DataSegmentChangeCallback.NOOP),
Review Comment:
Yes, that is the intention here. But just to clarify, this was already the
case and has not been introduced by this PR. I have only renamed the methods to
remove ambiguity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
