kfaraz commented on PR #14616: URL: https://github.com/apache/druid/pull/14616#issuecomment-1645772113
@gianm , there is another case which the current code was behaving weirdly. If a load keeps failing repeatedly on a historical, the coordinator may always get a PENDING response rather than FAILED. Typical scenario: - Coordinator requests Historical to load segment. - Request completes while load is still in progress and gets back a PENDING response - Then load fails and FAILED status is cached - Coordinator checks with the Historical if it has loaded the segment. - Since we already have a cached FAILED status, we retry the load and send back a PENDING response (see snippet below) - Repeat https://github.com/apache/druid/blob/efb32810c48fd9c0bf81cefb15179f74a4cde661/server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java#L562-L563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
