kfaraz commented on code in PR #14652:
URL: https://github.com/apache/druid/pull/14652#discussion_r1273576743
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -123,7 +107,7 @@ void checkForSegmentHandoffs()
}
}
if (!handOffCallbacks.isEmpty()) {
- log.warn("Still waiting for Handoff for [%d] Segments",
handOffCallbacks.size());
+ log.info("Still waiting for handoff for [%d] segments",
handOffCallbacks.size());
Review Comment:
Should we raise an alert if handoff wait time exceeds a threshold?
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -123,7 +107,7 @@ void checkForSegmentHandoffs()
}
}
if (!handOffCallbacks.isEmpty()) {
- log.warn("Still waiting for Handoff for [%d] Segments",
handOffCallbacks.size());
+ log.info("Still waiting for handoff for [%d] segments",
handOffCallbacks.size());
Review Comment:
Nit: "handoff **_of_** x segments"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
