yianni opened a new pull request, #14659:
URL: https://github.com/apache/druid/pull/14659

   ### Description
   
   This PR introduces the ability to add a cluster name as a Prometheus label. 
This is particularly useful when managing multiple Druid clusters and needing 
to distinguish between the metrics they emit.
   
   This was achieved by adding a new optional configuration parameter 
(`druid.emitter.prometheus.clusterName`) to the Prometheus emitter.
   
   ### Changes Made
   
   - Added a new configuration parameter 
(`druid.emitter.prometheus.clusterName`) to the Prometheus emitter.
   - Modified the PrometheusEmitter to include the cluster name as a Prometheus 
label if the configuration parameter is set.
   - Modified the unit tests to include and test this new functionality.
   
   ### Release note
   
   The Prometheus emitter now supports an additional optional configuration 
parameter, `druid.emitter.prometheus.clusterName`. This allows users to add a 
cluster name as a Prometheus label to distinguish between multiple Druid 
clusters.
   <hr>
   Key changed/added classes in this PR:
   - PrometheusEmitter
   - PrometheusEmitterConfig
   - PrometheusEmitterTest
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] added a release note entry in the PR description.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to