abhishekrb19 commented on code in PR #14659:
URL: https://github.com/apache/druid/pull/14659#discussion_r1275721392
##########
extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitterConfig.java:
##########
@@ -137,6 +143,11 @@ public boolean isAddServiceAsLabel()
return addServiceAsLabel;
}
+ public String getClusterName()
Review Comment:
```suggestion
@Nullable
public String getClusterName()
```
##########
extensions-contrib/prometheus-emitter/src/test/java/org/apache/druid/emitter/prometheus/MetricsTest.java:
##########
@@ -28,22 +28,24 @@ public class MetricsTest
@Test
public void testMetricsConfiguration()
{
- Metrics metrics = new Metrics("test", null, true, true);
+ Metrics metrics = new Metrics("test", null, true, true, "test_cluster");
Review Comment:
Can we add another unit test with the default `null` passed in as cluster
name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
