clintropolis opened a new pull request, #14710:
URL: https://github.com/apache/druid/pull/14710
### Description
Fixes a bug that can occur with `ExprEval.bestEffortOf` (used by 'auto'
column indexers and the web-console sampler) whenever dealing with ARRAY types
that have a lot of variation in their content. The problem was the `castTo` for
primitive types implementation for `ARRAY` types was only handling casting to
primitive arrays. This meant that an input array with types mixed such as
`["string", [{"some":"object'}]]` would fail because it would try to cast
`STRING` to `ARRAY<COMPLEX<json>>` which was unhandled. The fix is to delegate
casting to arbitrary array types by casting the value first to the array
element type, and wrapping that in an `Object[]` and making an `ArrayExprEval`
the same way we do for other array casts. The added tests cover this case (and
a couple other cases).
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
