clintropolis opened a new pull request, #14729:
URL: https://github.com/apache/druid/pull/14729
### Description
Fixes a case I missed in #14688 when the return type is STRING but its
coming from a top level array typed column instead of a nested array column
while making a vector object selector.
Also while here I noticed that the internal `JSON_VALUE` functions for array
types were named inconsistently with the non-array functions, so I renamed
them. These are not documented so it should not be disruptive in any way, since
they are only used internally for rewrites while planning to make the correctly
virtual column.
* `JSON_VALUE_RETURNING_ARRAY_VARCHAR` -> `JSON_VALUE_ARRAY_VARCHAR`
* `JSON_VALUE_RETURNING_ARRAY_BIGINT` -> `JSON_VALUE_ARRAY_BIGINT`
* `JSON_VALUE_RETURNING_ARRAY_DOUBLE` -> `JSON_VALUE_ARRAY_DOUBLE`
The internal non-array functions are `JSON_VALUE_VARCHAR`,
`JSON_VALUE_BIGINT`, and `JSON_VALUE_DOUBLE`.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
