kfaraz commented on code in PR #14714:
URL: https://github.com/apache/druid/pull/14714#discussion_r1281397110
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3TaskLogs.java:
##########
@@ -67,6 +67,11 @@ public S3TaskLogs(
public Optional<InputStream> streamTaskLog(final String taskid, final long
offset) throws IOException
{
final String taskKey = getTaskLogKey(taskid, "log");
+ // this is to satisfy CodeQL scan
+ Preconditions.checkArgument(
+ offset < Long.MAX_VALUE && offset > Long.MIN_VALUE,
Review Comment:
I think we can ignore the CodeQL scan for now because I am not entirely sure
if Long.MIN_VALUE or Long.MAX_VALUE are not being used anywhere on purpose to
represent some special scenarios.
The scan might also go away if we make the suggested change of adding a new
method rather than updating the existing one. Although, I am not entirely sure
if it will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
