YongGang opened a new pull request, #14714:
URL: https://github.com/apache/druid/pull/14714

   ### Description
   Saw the following error when fetching task status from S3. This is due to S3 
rate limiting on query, we should retry the operation in this case.
   ```
   com.amazonaws.services.s3.model.AmazonS3Exception: Slow Down (Service: 
Amazon S3; Status Code: 503; Error Code: 503 Slow Down; Request ID:; S3 
Extended Request ID: ; Proxy: null)
        at 
com.amazonaws.http.AmazonHttpClient$RequestExecutor.handleErrorResponse(AmazonHttpClient.java:1879)
 ~[aws-java-sdk-core-1.12.317.jar:?]
        at 
com.amazonaws.http.AmazonHttpClient$RequestExecutor.handleServiceErrorResponse(AmazonHttpClient.java:1418)
 ~[aws-java-sdk-core-1.12.317.jar:?]
        at 
com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeOneRequest(AmazonHttpClient.java:1387)
 ~[aws-java-sdk-core-1.12.317.jar:?]
        at 
com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:1157)
 ~[aws-java-sdk-core-1.12.317.jar:?]
        at 
com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:814)
 ~[aws-java-sdk-core-1.12.317.jar:?]
        at 
com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:781)
 ~[aws-java-sdk-core-1.12.317.jar:?]
        at 
com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:755)
 ~[aws-java-sdk-core-1.12.317.jar:?]
        at 
com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$500(AmazonHttpClient.java:715)
 ~[aws-java-sdk-core-1.12.317.jar:?]
        at 
com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:697)
 ~[aws-java-sdk-core-1.12.317.jar:?]
        at 
com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:561) 
~[aws-java-sdk-core-1.12.317.jar:?]
        at 
com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:541) 
~[aws-java-sdk-core-1.12.317.jar:?]
        at 
com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5456) 
~[aws-java-sdk-s3-1.12.317.jar:?]
        at 
com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5403) 
~[aws-java-sdk-s3-1.12.317.jar:?]
        at 
com.amazonaws.services.s3.AmazonS3Client.getObjectMetadata(AmazonS3Client.java:1372)
 ~[aws-java-sdk-s3-1.12.317.jar:?]
        at 
org.apache.druid.storage.s3.ServerSideEncryptingAmazonS3.getObjectMetadata(ServerSideEncryptingAmazonS3.java:97)
 ~[?:?]
        at 
org.apache.druid.storage.s3.S3TaskLogs.streamTaskFile(S3TaskLogs.java:90) ~[?:?]
   
   ```
   Now change to use `S3Utils.retryS3Operation` for task log fetch, same as 
task file push method.
   
   #### Release note
   Retry S3 task log fetch
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * make `streamTaskFile` method retry on transient S3 error in `S3TaskLogs` 
class
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   
   - [x] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to