abhishekagarwal87 commented on code in PR #14424:
URL: https://github.com/apache/druid/pull/14424#discussion_r1284256567
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaIndexTaskIOConfig.java:
##########
@@ -78,9 +82,10 @@ public KafkaIndexTaskIOConfig(
this.consumerProperties = Preconditions.checkNotNull(consumerProperties,
"consumerProperties");
this.pollTimeout = pollTimeout != null ? pollTimeout :
KafkaSupervisorIOConfig.DEFAULT_POLL_TIMEOUT_MILLIS;
this.configOverrides = configOverrides;
+ this.multiTopic = multiTopic != null ? multiTopic :
KafkaSupervisorIOConfig.DEFAULT_IS_MULTI_TOPIC;
Review Comment:
ah, there is a function for everything 😄 this one I will pass on if its ok
with you.
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaIndexTaskIOConfig.java:
##########
@@ -78,9 +82,10 @@ public KafkaIndexTaskIOConfig(
this.consumerProperties = Preconditions.checkNotNull(consumerProperties,
"consumerProperties");
this.pollTimeout = pollTimeout != null ? pollTimeout :
KafkaSupervisorIOConfig.DEFAULT_POLL_TIMEOUT_MILLIS;
this.configOverrides = configOverrides;
+ this.multiTopic = multiTopic != null ? multiTopic :
KafkaSupervisorIOConfig.DEFAULT_IS_MULTI_TOPIC;
Review Comment:
ah, there is a function for everything 😄 this one I will pass on if its ok
with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
