abhishekagarwal87 commented on code in PR #14424:
URL: https://github.com/apache/druid/pull/14424#discussion_r1293266366
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaRecordSupplier.java:
##########
@@ -55,20 +57,29 @@
import java.util.Properties;
import java.util.Set;
import java.util.concurrent.Callable;
+import java.util.function.Function;
import java.util.stream.Collectors;
-public class KafkaRecordSupplier implements RecordSupplier<Integer, Long,
KafkaRecordEntity>
+public class KafkaRecordSupplier implements
RecordSupplier<KafkaTopicPartition, Long, KafkaRecordEntity>
{
private final KafkaConsumer<byte[], byte[]> consumer;
private boolean closed;
+ private boolean multiTopic;
+
+ // Store the stream information when partitions get assigned. This is
required because the consumer does not
+ // know about the parent stream which could be a list of topics.
+ private String stream;
Review Comment:
don't think that is needed. its updated only during the assign and other
methods can't be called till we have done an assignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
