georgew5656 commented on code in PR #14758:
URL: https://github.com/apache/druid/pull/14758#discussion_r1285873512
##########
processing/src/test/java/org/apache/druid/indexer/TaskLocationTest.java:
##########
@@ -54,6 +54,18 @@ public void testTlsForPeonJobs()
Assert.assertEquals(2, tls.getTlsPort());
}
+ @Test
+ public void testDefaultK8sJobName()
+ {
+ TaskLocation noK8sJobName = TaskLocation.create("foo", 1, 2, false);
+ Assert.assertNull(noK8sJobName.getK8sPodName());
+ noK8sJobName = TaskLocation.create("foo", 1, 2);
+ Assert.assertNull(noK8sJobName.getK8sPodName());
+
+ TaskLocation k8sJobName = TaskLocation.create("foo", 1, 2, false,
"job-name");
+ Assert.assertEquals("job-name", k8sJobName.getK8sPodName());
Review Comment:
k8sJobName != k8sPodName, in this case i think the pod name is more useful
but we could add both if needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
