georgew5656 opened a new pull request, #14758: URL: https://github.com/apache/druid/pull/14758
Adds pod name to the TaskLocation object for Kubernetes task scheduling to make debugging easier. ### Description Since the task id <-> kubernetse pod name mapping is not direct and hard to figure out, its helpful for debugging to show the pod name in the druid console. I think it makes sense to add this to task location since the pod the task is running on is sort of like the location when running tasks in K8s. I also added a log message on the overlord when the task location is set because this is useful for forensics (taskLocation is cleared when the task finishes) #### Fixed the bug ... #### Renamed the class ... #### Added a forbidden-apis entry ... I thought about just putting the pod name into the task object itself, but i liked the idea of having it in taskLocation in case we ever have some concept of retrying tasks on pods (which would result in a task running as a different pod name) #### Release note - Surface kubernetes pod name in the K8sTaskRunner to improve visibility and forensics. ##### Key changed/added classes in this PR * TaskLocation * KubernetesPeonLifecycle This is what the task location looks like in the druid console now. <img width="1405" alt="Screenshot 2023-08-04 at 10 54 24 AM" src="https://github.com/apache/druid/assets/17736581/3c5a01dc-78eb-496a-a797-894fe8b31788";> If the field is null (e.g. when not running the k8s task runner) nothing will show up under k8sPodName. This PR has: - [X] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [X] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
