somu-imply commented on code in PR #14510:
URL: https://github.com/apache/druid/pull/14510#discussion_r1286027923


##########
pom.xml:
##########
@@ -80,13 +80,15 @@
         <apache.ranger.version>2.0.0</apache.ranger.version>
         <apache.ranger.gson.version>2.2.4</apache.ranger.gson.version>
         <scala.library.version>2.13.9</scala.library.version>
-        <avatica.version>1.17.0</avatica.version>
+        <avatica.version>1.23.0</avatica.version>
         <avro.version>1.11.1</avro.version>
-        <!-- sql/src/main/codegen/config.fmpp is based on a file from 
calcite-core, and needs to be
-          updated when upgrading Calcite. Refer to the top-level comments in 
that file for details.
-          Also, CalcitePlanner is a clone of Calcite's PlannerImpl and may 
require updates when
-          Calcite is upgrade. -->
-        <calcite.version>1.21.0</calcite.version>
+        <!-- When updating Calcite, also propagate updates to these files 
which we've copied and modified:
+             * sql/src/main/codegen/config.fmpp
+               - original: core/src/main/codegen/config.fmpp

Review Comment:
   Removed this



##########
processing/src/main/java/org/apache/druid/query/FilterDataSource.java:
##########
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.query;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.google.common.collect.ImmutableList;
+import org.apache.druid.java.util.common.IAE;
+import org.apache.druid.query.filter.DimFilter;
+import org.apache.druid.query.planning.DataSourceAnalysis;
+import org.apache.druid.segment.FilterSegmentReference;
+import org.apache.druid.segment.SegmentReference;
+import org.apache.druid.utils.JvmUtils;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Function;
+
+public class FilterDataSource implements DataSource

Review Comment:
   Javadics added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to