somu-imply commented on code in PR #14510:
URL: https://github.com/apache/druid/pull/14510#discussion_r1286033880
##########
sql/src/main/java/org/apache/druid/sql/calcite/rule/GroupByRules.java:
##########
@@ -64,6 +65,11 @@ public static Aggregation translateAggregateCall(
final boolean finalizeAggregations
)
{
+ if (!call.getCollation().getFieldCollations().isEmpty()) {
+ // TODO(gianm): validate no WITHIN GROUP elsewhere, mention location of
validation code here
Review Comment:
Will remove the todo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
