petermarshallio commented on code in PR #14683:
URL: https://github.com/apache/druid/pull/14683#discussion_r1288103699
##########
examples/quickstart/jupyter-notebooks/notebooks/99-contributing/notebook-template.ipynb:
##########
@@ -94,15 +114,146 @@
"metadata": {},
"outputs": [],
"source": [
- "# INCLUDE THIS CELL IF YOUR NOTEBOOK USES KAFKA \n",
- "# Use kafka_host variable when connecting to kafka \n",
- "import os\n",
- "\n",
"if 'KAFKA_HOST' not in os.environ.keys():\n",
" kafka_host=f\"http://localhost:9092\"\n";,
"else:\n",
" kafka_host=f\"{os.environ['KAFKA_HOST']}:9092\""
]
+ },
+ {
+ "cell_type": "markdown",
+ "id": "472589e4-1026-4b3b-bb79-eedabb2b44c4",
+ "metadata": {},
+ "source": [
+ "<!-- Include these cells if you're relying on someone ingesting example
data through the console -->\n",
Review Comment:
For the experience to be good here – especially when the required example
data is as large as the set required for, say, the Distinct Count or Top N
notebooks – I believe @sergioferragut is working on an update to the druidapi
so it provides feedback on status and progress.
##########
examples/quickstart/jupyter-notebooks/notebooks/99-contributing/notebook-template.ipynb:
##########
@@ -94,15 +114,146 @@
"metadata": {},
"outputs": [],
"source": [
- "# INCLUDE THIS CELL IF YOUR NOTEBOOK USES KAFKA \n",
- "# Use kafka_host variable when connecting to kafka \n",
- "import os\n",
- "\n",
"if 'KAFKA_HOST' not in os.environ.keys():\n",
" kafka_host=f\"http://localhost:9092\"\n";,
"else:\n",
" kafka_host=f\"{os.environ['KAFKA_HOST']}:9092\""
]
+ },
+ {
+ "cell_type": "markdown",
+ "id": "472589e4-1026-4b3b-bb79-eedabb2b44c4",
+ "metadata": {},
+ "source": [
+ "<!-- Include these cells if you're relying on someone ingesting example
data through the console -->\n",
Review Comment:
For the experience to be good here – especially when the required example
data is as large as the set required for, say, the Distinct Count or Top N
notebooks – I believe @sergioferragut is working on an update to the druidapi
so it provides feedback on status and progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
