LakshSingla commented on code in PR #13756:
URL: https://github.com/apache/druid/pull/13756#discussion_r1294899595
##########
docs/_bin/init-metadata.sh:
##########
@@ -0,0 +1,65 @@
+#!/bin/bash
+
+# Fail fast on any error
+set -e
+
+mysql()
+{
+ cd ${DRUID_ROOT}
+ java -classpath "lib/*"
-Dlog4j.configurationFile=conf/druid/cluster/_common/log4j2.xml
-Ddruid.extensions.directory="extensions"
-Ddruid.extensions.loadList="[\"mysql-metadata-storage\"]"
-Ddruid.metadata.storage.type=mysql -Ddruid.node.type=metadata-init
org.apache.druid.cli.Main tools metadata-init --connectURI=$connectURI --user
$username --password $password --base druid
Review Comment:
There seems to be some duplication between `mysql()` command and the
`postgresql()` command. Can they be refactored easily to remove that
redundancy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
