vogievetsky commented on code in PR #14828: URL: https://github.com/apache/druid/pull/14828#discussion_r1294934790
########## docs/development/extensions-core/kafka-supervisor-reference.md: ########## @@ -37,7 +37,7 @@ This topic contains configuration reference information for the Apache Kafka sup |Field|Type|Description|Required| |-----|----|-----------|--------| -|`topic`|String|The Kafka topic to read from. Must be a specific topic. Topic patterns are not supported.|yes| +|`topic`|String|The Kafka topic to read from. Must be a specific topic. Topic patterns are supported if `multiTopic` is enabled.|yes| Review Comment: I think this should be restructured slightly to a form like this: ``` If `multiTopic` is not set (or false) then `topic` is treated as a string that represents the Kafka topic from which the data will be read. If `multiTopic` is true then `topic` represents a regular expression that can match (exactly) several topics. ``` One of the things I am not clear on (and want to see documentation for) is the `exactly` part. Is the topic regex anchored in the start and end? If I have topics like `metrics-stage`, `metrics-dev`, `metrics-prod` if multiTopic is true should topic be set to `metrics-` or `metrics-.*` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
