abhishekagarwal87 commented on code in PR #14828: URL: https://github.com/apache/druid/pull/14828#discussion_r1295432790
########## docs/development/extensions-core/kafka-supervisor-reference.md: ########## @@ -37,7 +37,7 @@ This topic contains configuration reference information for the Apache Kafka sup |Field|Type|Description|Required| |-----|----|-----------|--------| -|`topic`|String|The Kafka topic to read from. Must be a specific topic. Topic patterns are not supported.|yes| +|`topic`|String|The Kafka topic to read from. Must be a specific topic. Topic patterns are supported if `multiTopic` is enabled.|yes| Review Comment: actually thinking a bit more about it, maybe I can get rid of multiTopic setting and instead add `topicPattern`. Since `topicPattern` is still a string, we can use it as `stream` while reporting metrics. It's expected that either the topic or topicPattern will be set by the user. This is same as what you had proposed earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
