clintropolis commented on code in PR #14195:
URL: https://github.com/apache/druid/pull/14195#discussion_r1295028080
##########
sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/EarliestLatestAnySqlAggregator.java:
##########
@@ -109,7 +111,7 @@ AggregatorFactory createAggregatorFactory(String name,
String fieldName, String
return new DoubleLastAggregatorFactory(name, fieldName,
timeColumn);
case STRING:
case COMPLEX:
- return new StringLastAggregatorFactory(name, fieldName,
timeColumn, maxStringBytes);
+ return new StringLastAggregatorFactory(name, fieldName,
timeColumn, null, maxStringBytes, true);
Review Comment:
same comment about `COMPLEX` case and `foldColumn`.
##########
processing/src/main/java/org/apache/druid/query/aggregation/post/PostAggregatorIds.java:
##########
@@ -66,4 +66,5 @@ public class PostAggregatorIds
public static final byte KLL_FLOATS_SKETCH_TO_QUANTILE_CACHE_TYPE_ID = 42;
public static final byte KLL_FLOATS_SKETCH_TO_QUANTILES_CACHE_TYPE_ID = 43;
public static final byte KLL_FLOATS_SKETCH_TO_STRING_CACHE_TYPE_ID = 44;
+ public static final byte PAIRS = 45;
Review Comment:
this isn't needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
