clintropolis commented on code in PR #14195:
URL: https://github.com/apache/druid/pull/14195#discussion_r1295010735
##########
processing/src/main/java/org/apache/druid/query/aggregation/last/StringLastAggregatorFactory.java:
##########
@@ -87,37 +103,71 @@ public void aggregate(ByteBuffer buf, int position)
}
};
+ private final String name;
private final String fieldName;
private final String timeColumn;
- private final String name;
+ private final String foldColumn;
protected final int maxStringBytes;
+ private final boolean finalize;
@JsonCreator
public StringLastAggregatorFactory(
@JsonProperty("name") String name,
- @JsonProperty("fieldName") final String fieldName,
+ @JsonProperty("fieldName") @Nullable final String fieldName,
@JsonProperty("timeColumn") @Nullable final String timeColumn,
- @JsonProperty("maxStringBytes") Integer maxStringBytes
+ @JsonProperty("foldColumn") @Nullable final String foldColumn,
Review Comment:
same comment about `foldColumn` vs just using `ColumnCapabilities`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
