ektravel commented on code in PR #14799: URL: https://github.com/apache/druid/pull/14799#discussion_r1300383971
########## docs/operations/metrics.md: ########## @@ -162,24 +165,25 @@ If SQL is enabled, the Broker will emit the following metrics for SQL. |`ingest/segments/count`|Count of final segments created by job (includes tombstones). | `dataSource`, `taskId`, `taskType`, `groupId`, `taskIngestionMode`, `tags` |At least `1`.| |`ingest/tombstones/count`|Count of tombstones created by job. | `dataSource`, `taskId`, `taskType`, `groupId`, `taskIngestionMode`, `tags` |Zero or more for replace. Always zero for non-replace tasks (always zero for legacy replace, see below).| -The `taskIngestionMode` dimension includes the following modes: -* `APPEND`: a native ingestion job appending to existing segments +The `taskIngestionMode` dimension includes the following modes: + +* `APPEND`: a native ingestion job appending to existing segments * `REPLACE_LEGACY`: the original replace before tombstones * `REPLACE`: a native ingestion job replacing existing segments using tombstones The mode is decided using the values of the `isAppendToExisting` and `isDropExisting` flags in the task's `IOConfig` as follows: -|`isAppendToExisting`|`isDropExisting`|Mode| -|--------------------|----------------|----| -|`true`|`false`|`APPEND`| -|`true`|`true `|Invalid combination, exception thrown.| -|`false`|`false`|`REPLACE_LEGACY`. The default for JSON-based batch ingestion. | -|`false`|`true`|`REPLACE`| +| `isAppendToExisting` | `isDropExisting` | mode | Review Comment: ```suggestion |`isAppendToExisting`|`isDropExisting`|mode| ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
