ektravel commented on code in PR #14799: URL: https://github.com/apache/druid/pull/14799#discussion_r1300389469
########## docs/operations/metrics.md: ########## @@ -279,7 +284,8 @@ If the JVM does not support CPU time measurement for the current thread, `ingest ## Shuffle metrics (Native parallel task) -The shuffle metrics can be enabled by adding `org.apache.druid.indexing.worker.shuffle.ShuffleMonitor` in `druid.monitoring.monitors` +The shuffle metrics can be enabled by adding `org.apache.druid.indexing.worker.shuffle.ShuffleMonitor` +in `druid.monitoring.monitors` Review Comment: Remove line 288. ########## docs/operations/metrics.md: ########## @@ -279,7 +284,8 @@ If the JVM does not support CPU time measurement for the current thread, `ingest ## Shuffle metrics (Native parallel task) -The shuffle metrics can be enabled by adding `org.apache.druid.indexing.worker.shuffle.ShuffleMonitor` in `druid.monitoring.monitors` +The shuffle metrics can be enabled by adding `org.apache.druid.indexing.worker.shuffle.ShuffleMonitor` Review Comment: ```suggestion The shuffle metrics can be enabled by adding `org.apache.druid.indexing.worker.shuffle.ShuffleMonitor` in `druid.monitoring.monitors`. ``` ########## docs/operations/metrics.md: ########## @@ -279,7 +284,8 @@ If the JVM does not support CPU time measurement for the current thread, `ingest ## Shuffle metrics (Native parallel task) -The shuffle metrics can be enabled by adding `org.apache.druid.indexing.worker.shuffle.ShuffleMonitor` in `druid.monitoring.monitors` +The shuffle metrics can be enabled by adding `org.apache.druid.indexing.worker.shuffle.ShuffleMonitor` +in `druid.monitoring.monitors` Review Comment: ```suggestion in `druid.monitoring.monitors`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
