clintropolis commented on code in PR #14866: URL: https://github.com/apache/druid/pull/14866#discussion_r1302460313
########## docs/configuration/index.md: ########## @@ -2026,8 +2026,8 @@ You can optionally only configure caching to be enabled on the Broker by setting See [cache configuration](#cache-configuration) for how to configure cache settings. :::info - Note: Even if cache is enabled, for [groupBy v2](../querying/groupbyquery.md#strategies) queries, segment level cache do not work on Brokers. - See [Differences between v1 and v2](../querying/groupbyquery.md#differences-between-v1-and-v2) and [Query caching](../querying/caching.md) for more information. + Note: Even if cache is enabled, for [groupBy](../querying/groupbyquery.md) queries, segment level cache does not work on Brokers. + See [query caching](../querying/caching.md) for more information. Review Comment: I guess like... I disagree, but we have a lot of other links doing that too. Like take this example: <img width="904" alt="Screenshot 2023-08-22 at 9 08 33 PM" src="https://github.com/apache/druid/assets/1577461/1e43e967-3ccc-4848-b4e1-e100ba59341f";> Why should the A in "Advance groupBy v2 configurations" and the M in "Memory tuning and resource limits" be uppercase? Is this a matter of perspective? Like it bothers me because I view these inline links as just some text that is part of a sentence that happen to be clickable. But i guess another perspective might be that this is some proper section title and it should match as closely as possible? I still don't really personally like it, but i changed it because a handful of other links are like this on this and other pages (not all of them though...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
