clintropolis opened a new pull request, #14866:
URL: https://github.com/apache/druid/pull/14866
### Description
This PR removes the 'v1' grouping engine as well as the strategy selection
abstraction. I found `GroupByStrategyV2` to still be a relatively handy thing
to keep around since it is a nice container for grabbing the resources and
stuff needed and plumbing to the underlying group by v2 engine, so I have
transitioned it into a new class `GroupingEngine` which is now used in place of
prior uses of `GroupByStrategySelector`.
#### Release note
The V1 group by query has been removed in favor of always using the V2
engine. Any query context parameters associated with it will now be ignored
internally.
`AggregatorFactory.getRequiredColumns` has been deprecated and will be
removed in a future release. If you have an extension that implements
`AggregatorFactory` then this method should be removed from your implementation
(there is now a default definition that throws an exception about being
deprecated).
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
