kfaraz commented on code in PR #14895:
URL: https://github.com/apache/druid/pull/14895#discussion_r1303782709
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -188,7 +186,7 @@ protected synchronized TaskStatus join(long timeout) throws
IllegalStateExceptio
*/
protected void shutdown()
{
- if (State.PENDING.equals(state.get()) ||
State.RUNNING.equals(state.get())) {
+ if (State.PENDING.equals(state.get()) || State.RUNNING.equals(state.get())
|| State.STOPPED.equals(state.get())) {
Review Comment:
Why do we need to handle STOPPED state here? Wouldn't the job have already
finished?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
